Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve binding error #6553

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

eliemichel
Copy link
Contributor

@eliemichel eliemichel commented Nov 15, 2024

Description
Error messages in case of a mismatch between resource binding as it is in the shader and as it is in the binding layout only say "there is a mismatch" without precising what binding type was found where. This improves the error message.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@eliemichel eliemichel requested a review from a team as a code owner November 15, 2024 19:00
@eliemichel eliemichel marked this pull request as draft November 15, 2024 19:06
@eliemichel eliemichel marked this pull request as ready for review November 15, 2024 19:38
wgpu-core/src/validation.rs Outdated Show resolved Hide resolved
@ErichDonGubler ErichDonGubler self-assigned this Nov 15, 2024
@ErichDonGubler ErichDonGubler added the kind: diagnostics Error message should be better label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: diagnostics Error message should be better
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants